remove ~ in path when cooking on a windows host to prevent the creati… #462
Conversation
|
Seems reasonable, but I'll need to sort out the test failures first. Looks more like something upstream than this change though. |
|
sure. Anything I can help with ? On Wed, Nov 11, 2015 at 10:08 AM, Mat Schaffer notifications@github.com
|
|
Feel like doing a bisect of chef releases to see which one broke it? ;) On Thursday, 12 November 2015, Fabien Jakimowicz notifications@github.com
-Mat matschaffer.com |
|
I can give it a shot. Can you tell me where to start from and what is expected to fail ? On Thu, Nov 12, 2015 at 12:18 AM, Mat Schaffer notifications@github.com
|
|
The failing tests on travis will show it. The previous successes probably The travis yaml includes info about how to run with our different gem files -Mat matschaffer.com On Thu, Nov 12, 2015 at 8:27 AM, Fabien Jakimowicz <notifications@github.com
|
|
@jakimowicz I found the failure. #463 has the details. Can you rebase this on master to get a clean build? |
|
Actually just noticed that |
jakimowicz
force-pushed
the
improvement/windows_support
branch
from
b0cd562
to
9951ac5
Compare
…on of a folder named ~ which is not usable by chef
jakimowicz
force-pushed
the
improvement/windows_support
branch
from
9951ac5
to
21a2de2
Compare
|
I rebased the branch, but I still have some test failing related to an incorrect dns resolution. Is it something you already encountered ? |
|
That's related to your change. I suspect we need a stub on windows_node? Otherwise it tries to call out to see if the current node is window or not. On Sunday, 22 November 2015, Fabien Jakimowicz notifications@github.com
-Mat matschaffer.com |
|
yeah, that's what I figured out. I'll make the appropriate changes to fix it. Thanks again. On Sun, Nov 22, 2015 at 11:38 AM, Mat Schaffer notifications@github.com
|
|
The pleasure's all mine :) |
* master: A note about the chefdk/berkshelf issue. Removed an unsuitable package info Removed an unsuitable package info Set a specific version for json and mixlib-config downgrade json-1.8.2 > 1.8.1 Resolved some of dependencies for ohai and tins to get the test passing (chef-10, chef-11) Skip any interactive post-install configuration steps when running first prepare command for Debian x86 Include remote user and port in ssh control path replaced eval with const_get method
|
I just added the stub and a test for my change, but some builds are failing, some passes. I also merged from master to be sure it was not caused by a recent change, but it still fails. Since the code did not change much from master, is it normal ? |
|
Looks like it could be a dependency that drifted. I'd make sure you're rebased off the latest master, though I thing the travis/pr job tests the merge so not sure if that will make a difference. If it doesn't either you or I will have to figure out what's causing the error and lock versions appropriately. |
* master: (28 commits) Add support for OpenSUSE Leap Bump version for next release Set release date Clarify comment about `ENV['PWD']` Changelog update Update manifest Update test now that control master is off by default Update OmniOS to latest LTS Generalize handling of ssh key arguments for older or newer knifes Pass ssh_identity_file as well as identity_file through as ssh keys Set ENV['PWD'] when switching pwd into integration test kitchen Removing archlinux test Removing gentoo test WIP CentOS 7 test Remove old debian & centos tests since apache2 no longer supports them Switch up nc command Default control master to "no" Update amazon linux integration Take out doc warning now that chefdk issue is worked out Map missing changelog links ...
…on of a folder named ~ which is not usable by chef